Add -p short flag for pretty command #228
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -p short flag was conflicting with other options (proxy, password, path), causing CLI parsing errors and failing tests. Changed the short flag for --pretty to -P to avoid conflicts while keeping it intuitive. This restores test passes for all CLI flag positions and maintains backward compatibility.
Pull Request Test Coverage Report for Build 19788352634Details
💛 - Coveralls |
tvpeter
reviewed
Jan 9, 2026
Collaborator
tvpeter
left a comment
tvpeter
left a comment
There was a problem hiding this comment.
Hi @AmosOO7,
Thank you for working on this. However, your suggestion of using an uppercase "P" does not align with the short naming convention used throughout the codebase. It would be more suitable to use a different letter, as seen in some instances in the code.
As an alternative, I would suggest using h for "human-readable form". If you can think of a better option, please feel free to update it, and I'll review it again.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a short
-Pflag as an alias for the existing--prettyoption to make the command easier and faster to use.This closes #226
Notes to the reviewers
The new
-Pflag behaves exactly the same as--pretty.No existing behavior is changed — this only introduces an additional alias.
Changelog notice
Added
-Pas a shorthand flag for theprettycommand.Checklists
All Submissions:
cargo fmtandcargo clippy